Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: phone number on ShippingContact is a string #1349

Merged

Conversation

huextrat
Copy link
Contributor

@huextrat huextrat commented Apr 6, 2023

Summary

phoneNumber type on ShippingContact for ApplePay is a string not a number

Motivation

Native mappers mapFromShippingContact give the phone number as a string but TS type is a number which is wrong.

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

Copy link
Collaborator

@charliecruzan-stripe charliecruzan-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@charliecruzan-stripe charliecruzan-stripe merged commit 5ead69e into stripe:master Apr 6, 2023
@huextrat huextrat deleted the fix/phone_number_type_apple_pay branch April 7, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants