-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reevaluate mobile menu positioning when custom logo set #332
Comments
I would agree with this, such a small item takes up a lot of real estate on a mobile, significantly reducing the amount of content above the fold. I would also argue to remove the 'Menu' text to reduce the width, most websites seem to be using the hamburger button on it's own anyway. |
I'm not an expert but I do caution against making such an assumption for accessibility purposes. It is certainly possible that a significant portion of users (if not all of them) understand what a hamburger menu is for. Perhaps a Customizer checkbox option that would allow the appropriate decision-makers to disable/enable the menu text feature based on accessibility compliance guidelines and user feedback? It would be a similar feature that I would like to see for disabling/enabling the sticky header, again for the same reason previously mentioned. |
wordpress.org uses hamburger button only, but not sure whether it is accessible, will take a closer look. |
The wordpress.org mobile-menu-button element includes
The text is hidden visually using the screen-reader-class, however the Genesis Sample menu-toggle element includes:
without the screen-reader-text class. There maybe other considerations for accessibility but that's the only obvious one I could find looking briefly at wordpress.org. |
We had a report that the mobile menu is pushed below the 720 x 120 custom logo at mobile screen widths (see below).
The menu opening animation is also not smooth when it appears like this (the menu scrolls open, then jumps below the menu button). We should consider:
The text was updated successfully, but these errors were encountered: