Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentHighlightProvider capability #24

Closed
ssoher opened this issue Nov 12, 2022 · 9 comments
Closed

documentHighlightProvider capability #24

ssoher opened this issue Nov 12, 2022 · 9 comments

Comments

@ssoher
Copy link

ssoher commented Nov 12, 2022

I find it useful when other occurances of the symbol under the caret are highlighted, makes it easy seeing the immediate usages. But this doesn't seem to work in LSP-OmniSharp even when I change document_highlight_style to background and add the related scopes with custom background colors to my color theme (using this as a guide https://lsp.sublimetext.io/customization/#document-highlights).

Do we have the required capability in the server, am I doing something wrong?

@rwols
Copy link
Member

rwols commented Nov 12, 2022

If you open the LSP log panel with “LSP: Toggle Log Panel”, then you can see what capabilities the server has exactly by looking at the response of the initialize request

@rwols
Copy link
Member

rwols commented Nov 12, 2022

Maybe easier: run view.run_command("lsp_dump_buffer_capabilities") in the ST console when you have a .cs file open.

@ssoher
Copy link
Author

ssoher commented Nov 12, 2022

@rwols I can't feel sad now that the answer is no since I've also learned something, thanks :)

Can we consider this "issue" a feature request then?

@rwols
Copy link
Member

rwols commented Nov 12, 2022

But maybe it's just a placeholder, I haven't looked much into it: OmniSharp/omnisharp-roslyn#2463

@rwols
Copy link
Member

rwols commented Nov 12, 2022

v1.39.2 should contain that functionality: https://github.com/OmniSharp/omnisharp-roslyn/releases/tag/v1.39.2

@rwols
Copy link
Member

rwols commented Nov 12, 2022

While we use v1.38.2:

VERSION = "1.38.2"

@ssoher
Copy link
Author

ssoher commented Nov 20, 2022

I can confirm that replacing the packaged omnisharp version with the latest release 1.39.2 does provide highlighting.

@deathaxe
Copy link
Contributor

Should be fixed by PR #40, which makes transition to latest .NET 6+ based OmniSharp binaries.

@rwols rwols closed this as completed Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants