Update language server #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ship: 1. v1.39.12 2. net6.0 based language-server (instead of net472/mono) 3. arm64 compatible language-server
|
Does this break current user's workflow when they don't have .NET 6 installed? I asked this a long time ago, but, I don't know if there's still a concern to be honest. |
|
It will break those, but mono has been deprecated long ago as well as .NET 4.7 on windows platform. Each recent Visual Studio ships .net6+ and it is an easy fix on Linux/MacOS as well. .NET 4.7 is also supported compile target on .net6+. So impact besides requiring .NET sdk should be rather low. |
|
I tested this on Ubuntu and it now complains about a mono executable missing. I see there’s an OmniSharp file that, when given executable permissions, is executable. I want to have this minor issue fixed for Linux before making a release. I’ll do this myself but I do welcome PRs. |
This was referenced Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ship: