Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy decoding #14

Closed
stwiname opened this issue Jun 13, 2022 · 0 comments · Fixed by #17
Closed

Lazy decoding #14

stwiname opened this issue Jun 13, 2022 · 0 comments · Fixed by #17

Comments

@stwiname
Copy link
Contributor

Currently if you don't provide all the message types then data will fail to decode and indexing will stop.

We should only decode data as its needed (if it passes filters) so that if data is not needed because its filtered out we don't decode it. This may also have some performance improvements as we're not decoding as much data.

We should be able to do a lot of this with lazy loading https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/get#smart_self-overwriting_lazy_getters

@guplersaxanoid guplersaxanoid linked a pull request Jun 15, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant