You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now that Cash is modularized, should we add the following methods?
outerHeight()
outerWidth()
innerHeight()
innerWidth()
They'd be useful for having more refined control of determining the size of elements without having to hardcode in magic numbers, or try to acquire the numbers with calls to getComputedStyle(elem);
The text was updated successfully, but these errors were encountered:
Now that we're modularized I'm generally fine with the addition of stuff like this. For the sake of argument, let's consider the following:
Where do we stop? Let's not rebuild jquery / zepto for the sake of it.
Are there cases where we need these methods right now?
Should "more complicated" methods like these be included into the existing, similar modules (i.e. heightWidth.js) or to a new module (i.e. advancedHeightWidth.js).
The Outer* are more useful IMO as the issue Brendan found was that the padding was, of course, not being reported by height(). I think the answer may be @bluesaunders 2nd point, better design. The need for it may just be a design 'smell'... I will put together a module for it, at some point, but it won't be in the default build
Now that Cash is modularized, should we add the following methods?
outerHeight()
outerWidth()
innerHeight()
innerWidth()
They'd be useful for having more refined control of determining the size of elements without having to hardcode in magic numbers, or try to acquire the numbers with calls to
getComputedStyle(elem);
The text was updated successfully, but these errors were encountered: