Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combination of On strong beat do and On every note do not working #1898

Closed
pikurasa opened this issue Nov 18, 2019 · 8 comments
Closed

Combination of On strong beat do and On every note do not working #1898

pikurasa opened this issue Nov 18, 2019 · 8 comments
Assignees

Comments

@pikurasa
Copy link
Collaborator

It seems that projects with both on strong beat do and on every note do do not work.

Example project:
Screenshot at 2019-11-18 10:11:59 on strong beat and on every note do
phone-number-song-combo -of-every-beat-and-every-note-not-working.html.zip

With the example project, try:

  • Putting on every note do at or near the top of start block. The project will only play one note, the low e.
  • Removing the on every note do block. (Also, the stack of notes in the start block plays back without guitar sound.)
  • Removing the on strong beat do block (I need to go right now...)
@walterbender
Copy link
Member

I think that the note in the action block is going to also trigger the arpeggio action. I'll dig into this.

@pikurasa
Copy link
Collaborator Author

I think that the note in the action block is going to also trigger the arpeggio action.

I do not think we ever want that kind of recursion for on every note do.

@walterbender
Copy link
Member

Here is a simple work-around while I try to figure out what is wrong.
mb.zip
Screenshot from 2019-11-23 19-15-20

@walterbender
Copy link
Member

Screenshot from 2020-01-20 21-13-37

I think this is more along the lines of what you wanted. Still trying to figure out where the root problem lies.

@pikurasa
Copy link
Collaborator Author

I think this is more along the lines of what you wanted.

Yes.

@sksum
Copy link
Member

sksum commented May 8, 2020

I would like to work on this issue (if its okay with @walterbender ) . I think the problem lies in the way "everybeat" and "strongbeat" beats are treated for the noteblock .

@walterbender
Copy link
Member

@sksum please do jump in on this. We were thinking that perhaps "on every beat" could behave a bit differently than currently designed: to be triggered on every beat in the defined meter, regardless of whether or not a note was played. Not 100% certain how we'd want to handle off-beat events but perhaps we can all discuss this together on Monday?

@sksum
Copy link
Member

sksum commented May 9, 2020

Sure @walterbender

walterbender pushed a commit that referenced this issue May 13, 2020
* handles cblk2 is null error

decrement function will work even when cblk2 : null

* Update RhythmBlocks.js

childFlow set to null after all of the properties are checked : everybeat , offbeat ....
@sksum sksum added the WF6-Needs testing Please test label Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants