Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat of zero (and below) #2263

Closed
pikurasa opened this issue May 14, 2020 · 7 comments
Closed

Repeat of zero (and below) #2263

pikurasa opened this issue May 14, 2020 · 7 comments
Labels

Comments

@pikurasa
Copy link
Collaborator

For repeat of less than 1, nothing happens (not even an error message)

Screenshot at 2020-05-14 12:56:46 repeat of zero

@pikurasa
Copy link
Collaborator Author

This becomes important when using boxes on certain operations.

@walterbender
Copy link
Member

What should happen?

@pikurasa
Copy link
Collaborator Author

What should happen?

I was hoping you might have an opinion about this.

Left to my own devices...

"Repeat zero times" means either to skip or to play once (same as repeat = 1). Skipping may be useful in certain situations.

Any negative number is illogical and should trigger an error.

Right now there is no error, so the user needs to hunt around a little bit.

@sum2it
Copy link
Collaborator

sum2it commented May 15, 2020

I would prefer that repeat zero skips the track, since that's mathematically appropriate even if it sounds counter-intuitive.

@sksum
Copy link
Member

sksum commented Jun 11, 2020

currently , it gives out a no input error message .
@walterbender thoughts ?
repeat 0 --> skip note
repeat -ve --> warning ,works same as repeat 0

@walterbender
Copy link
Member

repeat 0 should skip its child flow without an error message. Maybe an error message for < 0???

@sksum sksum added the WF6-Needs testing Please test label Jun 24, 2020
@walterbender
Copy link
Member

Screenshot from 2020-11-28 09-47-37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants