Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown Block on Custom Temperament Save #2347

Closed
pikurasa opened this issue Jun 12, 2020 · 2 comments
Closed

Unknown Block on Custom Temperament Save #2347

pikurasa opened this issue Jun 12, 2020 · 2 comments
Labels
Component-Temperament related to temperament Component-Widget relating to a widget WF6-Needs testing Please test

Comments

@pikurasa
Copy link
Collaborator

I think the "unknown" block is suppose to be a ratio for the specified octave.

Screenshot at 2020-06-12 08:32:36 unknown block for temperament

Logs:

block.js:182 Uncaught (in promise) Error: COULD NOT CREATE CACHE
    at checkBounds (block.js:182)
    at checkBounds (block.js:189)
    at checkBounds (block.js:189)
    at checkBounds (block.js:189)
    at checkBounds (block.js:189)
    at block.js:205
    at new Promise (<anonymous>)
    at Block._createCache (block.js:173)
    at __processHighlightBitmap (block.js:908)
    at Image.img.onload (block.js:7821)
5
block.js:182 Uncaught (in promise) Error: COULD NOT CREATE CACHE
    at checkBounds (block.js:182)
    at checkBounds (block.js:189)
    at checkBounds (block.js:189)
    at checkBounds (block.js:189)
    at checkBounds (block.js:189)
    at block.js:205
    at new Promise (<anonymous>)
    at Block._createCache (block.js:173)
    at __processHighlightBitmap (block.js:908)
    at Image.img.onload (block.js:7821)

Test File:
unknown-block-temperament.html.zip

Also, the "define temperament" clamp will not move when first created (although it does seem to move when you later open the test file).

@pikurasa pikurasa added Issue-Bug Component-Temperament related to temperament Component-Widget relating to a widget labels Jun 12, 2020
@sksum
Copy link
Member

sksum commented Jun 12, 2020

is the temperament block doing its job as expected ?

@pikurasa
Copy link
Collaborator Author

is the temperament block doing its job as expected ?

Yes, it seems to work.

There are some bugs in the widget, but I will report those separately.

@sksum sksum mentioned this issue Jun 13, 2020
@sksum sksum added WF6-Needs testing Please test and removed Issue-Bug labels Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component-Temperament related to temperament Component-Widget relating to a widget WF6-Needs testing Please test
Projects
None yet
Development

No branches or pull requests

3 participants