Scale Degree is acting "wonky"

[pikurasa]

I am having trouble finding the pattern, but the scale degree block is not working well on its own.

2-spelling-systems-for-Scale-Degree.html.zip

As a snapshot, you can see that the first pitch is not C (even though it is in C major and starts from SD=1). It seems to be making this lower C its seventh scale degree. Also, the two voices are not matching in pitch.

[pikurasa]

Tested on Rawgit.

[aviral243]

I'm probably subtracting 1 somewhere I shouldn't, or vice-versa. Must've happened when I refactored the function.
I'll take a look.

[pikurasa]

No worries!

Working on the docs right now!

[pikurasa]

I tested it and the sound works perfectly as expected for the test example.

However, when I try and export as Lilypond I get:

PitchBlocks.js:2041 Uncaught TypeError: Cannot read property 'indexOf' of undefined
    at ScaleDegree2Block.arg (PitchBlocks.js:2041)
    at Logo.parseArg (logo.js:841)
    at Logo.runFromBlockNow (logo.js:1691)
    at logo.js:1650
PitchBlocks.js:2041 Uncaught TypeError: Cannot read property 'indexOf' of undefined
    at ScaleDegree2Block.arg (PitchBlocks.js:2041)
    at Logo.parseArg (logo.js:841)
    at Logo.runFromBlockNow (logo.js:1691)
    at logo.js:1650

[walterbender]

@pikurasa please test

[walterbender]

[pikurasa]

Yes, this is working as expected.

I would like to add #2461 as I plan to reference it in documentation.