Pitch Preview Bugs and Enhancements

[pikurasa]

• Bug: For C# major (fixed), mi # (e#) and fa # (f#) sound the same (fa # plays as natural). Notably, for fa #, if you toggle to natural and back to sharp the pitch sounds correct.

• Bug: For G# major (fixed), ti # (b#) and do # (c#) sound the same (do # plays as natural). Notably, for do #, if you toggle to natural and back to sharp the pitch sounds correct.

(In both of the above cases, the issue is with the fourth scale degree when it is sharp. Flat seems to be fine.)

• Bug: For G# major (fixed), fa is being chosen as natural. It should be fa double sharp.

• Bug: Cb has no change whatsoever.

• Bug: Setting the mode (i.e. to minor, dorian, etc) has the wrong effect for scale degree blocks' pie menu pitch preview. Unlike movable do solfege, 1 should always be the first note of the mode. When we have movable=la, this will be how solfege works when set to movable=la. How scale degree blocks are functioning in the code behaves just fine, so please use this as a reference.

Reference Materials:

SD-Common-Modes.zip

• Bug: Three "set key" blocks are generated. Only one needs to be generated (for each visible Start Block).

• Enhancement: Please add something that says "solfege pitch preview" above where the "fixed" and "movable do" radio buttons reside.

• Enhancement: It would be nice if the pie menu played the following pitches (not just the tonic): Scale Degrees 1, 3, 5, 6, 4, 2, 7, 1. This would help someone get a better sense of the tonality.

Specifically (with note value and octave reference):

Preview Proposal.html.zip

[aviral243]

Some of these preview issues are a result of representational similarity in a few cases (like E# expressed as F). I'll see which ones we can eliminate.

re Cb Major: This is an issue with _buildScale(). Scale generated for Cb major is the same as C major.

re Scale Degree : Fix in order.

re Three set key blocks: I wasn't able to reproduce this. I seem to be able to generate one set key per start block. Please retry.

Regarding styling : Would this mild grey background help with visual and foster interconnectivity between pie-menu and moveable options?

[pikurasa]

Some of these preview issues are a result of representational similarity in a few cases (like E# expressed as F). I'll see which ones we can eliminate.

Internally?

re Cb Major: This is an issue with _buildScale(). Scale generated for Cb major is the same as C major.

I assume this is some internal issue.

If this is too difficult, we can only offer B Major (and other modes) as Cb is pretty far from C and less common.

Regarding styling : Would this mild grey background help with visual and foster interconnectivity between pie-menu and moveable options?

Yes, looks better. Please capitalize all the words -- "Solfege Pitch Preview"

[pikurasa]

• Enhancement: Change "Aeolian" to "Minor"

[pikurasa]

@aviral243 If there are overarching issues with _buildScale(), please document them in a new issue ticket. Thanks.

[aviral243]

@walterbender Let's keep this open for a while. I might be able to fix few more of the above-mentioned issues.

[pikurasa]

@aviral243 yes, please. I am afraid that if we don't sort out these bugs, this feature will cause more confusion than benefit.