Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression on Rawgit #2513

Closed
pikurasa opened this issue Aug 17, 2020 · 7 comments
Closed

Regression on Rawgit #2513

pikurasa opened this issue Aug 17, 2020 · 7 comments
Assignees
Labels
Issue-Regression Something that worked in the past is now broken WF6-Needs testing Please test

Comments

@pikurasa
Copy link
Collaborator

This metronome does not work on Rawgit: https://musicblocks.sugarlabs.org/index.html?id=1592058687652210&run=True

It doesn't run at all on Rawgit. The sugarlabs.org version has trouble syncing the graphics, but still runs.

Error in logs

Uncaught ReferenceError: _enqueue is not defined
    at Function.playNote (js/turtleactions/RhythmActions.js:80)
    at NewNoteBlock.flow (js/blocks/RhythmBlocks.js:789)
    at Logo.runFromBlockNow (js/logo.js:1597)
    at js/logo.js:1474
@pikurasa pikurasa added the Issue-Regression Something that worked in the past is now broken label Aug 17, 2020
@pikurasa
Copy link
Collaborator Author

I also tried the following on Rawgit and it is not working either: https://musicblocks.sugarlabs.org/index.html?id=1590682539166934&run=True

Errors in logs:

Uncaught ReferenceError: _enqueue is not defined
at Function.playNote (js/turtleactions/RhythmActions.js:75)
at NewNoteBlock.flow (js/blocks/RhythmBlocks.js:789)
at Logo.runFromBlockNow (js/logo.js:1597)
at js/logo.js:1474
RhythmActions.js:75 Uncaught ReferenceError: _enqueue is not defined
at Function.playNote (RhythmActions.js:75)
at NewNoteBlock.flow (RhythmBlocks.js:789)
at Logo.runFromBlockNow (logo.js:1597)
at logo.js:1474

@meganindya Is this related to your work?

@pikurasa
Copy link
Collaborator Author

For #2513 (comment), if I take out the on every note do block it works.

Screenshot at 2020-08-18 11:11:51

@meganindya
Copy link
Member

Could you share a .zip of the project. The links open the initial project in my case.

@pikurasa
Copy link
Collaborator Author

Perhaps "On Every Note Do" is broken.

The following simple project does not work with "On Every Note Do". It does, however, work with "On Every Beat Do".

Screenshot at 2020-08-23 10:39:25
On-Every-Note-Do-Every-Beat-Do.html.zip

I see this error when I run the above project with "on every note do".

ReferenceError: _enqueue is not defined RhythmActions.js:75:21
    playNote https://rawgit.com/sugarlabs/musicblocks/master/js/turtleactions/RhythmActions.js:75
    flow https://rawgit.com/sugarlabs/musicblocks/master/js/blocks/RhythmBlocks.js:789
    runFromBlockNow https://rawgit.com/sugarlabs/musicblocks/master/js/logo.js:1597
    delayTimeout https://rawgit.com/sugarlabs/musicblocks/master/js/logo.js:1474

@sksum
Copy link
Member

sksum commented Aug 23, 2020

your projects should work on this branch #2534 .

@pikurasa
Copy link
Collaborator Author

your projects should work on this branch #2534 .

Yes, it works.

@sksum sksum added the WF6-Needs testing Please test label Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Regression Something that worked in the past is now broken WF6-Needs testing Please test
Projects
None yet
Development

No branches or pull requests

4 participants