Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phrase Maker and Hertz #2533

Closed
pikurasa opened this issue Aug 22, 2020 · 2 comments
Closed

Phrase Maker and Hertz #2533

pikurasa opened this issue Aug 22, 2020 · 2 comments

Comments

@pikurasa
Copy link
Collaborator

One improvement and one bug related to hertz and phrase maker.

Hertz Numeric Value should not have more than 2 decimal places in Phrase Maker.

Please see:

Screenshot at 2020-08-22 14:31:41

Also, the button to order all the pitches results only in a single pitch:

Screenshot at 2020-08-22 14:35:16

Test File:

Pythagorean Fun!.html.zip
@pikurasa
Copy link
Collaborator Author

...maybe 3 decimal places, but certainly no more...

@sksum sksum mentioned this issue Aug 31, 2020
Merged
@walterbender
Copy link
Member

I don't think there should be any decimal places, actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@walterbender @pikurasa