oscilloscope continues to run after stop

[walterbender]

Checking the console output, line 103 in oscilloscope.js continues to generate spam after the stop button has been pressed.

[sksum]

"oscilloscope running" should log every frame while the widget is open , does it still log when the widget is closed ?

[walterbender]

I think it should not be running when the program is not running, even if it is open. Is that possible?

[walterbender]

(Check the console output to see what I mean... when the oscilloscope is running, the console is bombarded with output even if there is nothing else running.)

[ricknjacky]

Changes to the code :-

It should not be running when the program is not running, even if it is open.

The console output that I got:-

Does this match the behavior you expect? @walterbender

[walterbender]

That suppresses the log output but the code presumably is still running. We need to stop the code from running.

[ricknjacky]

When the widget is open the oscilloscope code should run? right? When we close the widget window it stops ig.

[walterbender]

It should also stop when the program execution stops, regardless of whether or not the widget is open.