Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support dictionary blocks in export-js #2587

Closed
walterbender opened this issue Nov 2, 2020 · 3 comments
Closed

support dictionary blocks in export-js #2587

walterbender opened this issue Nov 2, 2020 · 3 comments
Assignees
Labels
Component-JS Editor Specific to the JavaScript editor widget Issue-Enhancement

Comments

@walterbender
Copy link
Member

some code may need to move to turtleactions...

@walterbender walterbender added Issue-Enhancement Component-JS Editor Specific to the JavaScript editor widget labels Nov 2, 2020
@walterbender
Copy link
Member Author

from @meganindya

I checked the 6 new blocks — seem to be working fine. For export, the logic and graphics need to be totally separated, which didn't happen for the ensemble blocks and so those were pending.

The way for export is to start by separating the "action" logic into a file in turtleactions/. The methods in that file are called by those in the blocks/ when interfacing via the canvas, and from js-export/API/ when done via code. Now, finally, the blocks' intrinsic names are mapped to the API functions in js-export/interface.js.

I can follow the changes to DictBlocks.js. Maybe I can take this up.

Meanwhile, are you planning more changes to Dictionary / Ensemble blocks? I think the separation of concerns in DictBlocks.js to turtleactions/ is where we start.

@meganindya
Copy link
Member

Now that #2585 has been merged, can I start working on the export implementation of these blocks? I might want to touch logo.js and turtle.js along the way in an effort to standardize changes I implemented for the previously dealt blocks.

@walterbender
Copy link
Member Author

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component-JS Editor Specific to the JavaScript editor widget Issue-Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants