Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Manifest.json #2607

Closed
kushal-khare-official opened this issue Nov 22, 2020 · 4 comments · Fixed by #2608
Closed

Error in Manifest.json #2607

kushal-khare-official opened this issue Nov 22, 2020 · 4 comments · Fixed by #2608

Comments

@kushal-khare-official
Copy link
Contributor

Icons should be an array in Manifest.json file
Instead of the following code

"icons": {
        "512": "/activity/activity-icon-color-512.png",
      	"128": "/activity/activity-icon-color-128.png"
    },

the code should be this

"icons": [
    {
        "src": "/activity/activity-icon-color-512.png",
        "sizes": "512x512",
        "type": "image/png"
    },
    {
        "src": "/activity/activity-icon-color-128.png",
        "sizes": "128x128",
        "type": "image/png"
    }
],
@kushal-khare-official
Copy link
Contributor Author

@walterbender can I take this issue?

@walterbender
Copy link
Member

sure.

@walterbender
Copy link
Member

Can you please include a link to the manifest format documentation too?

@kushal-khare-official
Copy link
Contributor Author

@walterbender here is the link to manifest format documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants