-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add default strong /weak for meter block #2269
Conversation
default strong beats for common meters in meterwidget
set up default beats in meter block flow which will be removed whenever any strong beat block is queued
@pikurasa Somehow that project isn't working after this patch. Before this everything's fine. |
logo.beatList[turtle].push(1); | ||
logo.beatList[turtle].push(4); | ||
logo.defaultStrongBeats[turtle] = true; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something in this particular code snippet is interfering with our project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will look into it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It might help to compare the previous behavior of the project to the new one. I've attached it above. Might have to do something with multiple action blocks, but I'm not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this commit assigns strong beats by default , when you use a 4:4 meter in the action (transition) - (1, 3) become strong beats...
this is a issue we have been working on , we cant use strong beats and every note do together #1898 , #2258
for now you can remove the meter in the action (transition)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see. Yes, those issues have been bothersome from time to time. Happy to do any testing.
#2253
-meter widget will have default beats when we open
-if no strong beat block is used default values will be considered as strong beats(. but, to do some action on strong beats you would have to use strong beat blocks anyway )