Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default strong /weak for meter block #2269

Merged
merged 2 commits into from
May 17, 2020
Merged

Conversation

sksum
Copy link
Member

@sksum sksum commented May 17, 2020

#2253
-meter widget will have default beats when we open
-if no strong beat block is used default values will be considered as strong beats(. but, to do some action on strong beats you would have to use strong beat blocks anyway )

sksum added 2 commits May 17, 2020 05:48
default strong beats for common meters in meterwidget
set up default beats in meter block flow which will be removed whenever any strong beat block is queued
@walterbender walterbender merged commit 7d5d766 into sugarlabs:master May 17, 2020
@aviral243
Copy link
Member

@pikurasa Somehow that project isn't working after this patch. Before this everything's fine.

2020-05-12-Octave-Tests.zip

logo.beatList[turtle].push(1);
logo.beatList[turtle].push(4);
logo.defaultStrongBeats[turtle] = true;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something in this particular code snippet is interfering with our project.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look into it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It might help to compare the previous behavior of the project to the new one. I've attached it above. Might have to do something with multiple action blocks, but I'm not sure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this commit assigns strong beats by default , when you use a 4:4 meter in the action (transition) - (1, 3) become strong beats...
this is a issue we have been working on , we cant use strong beats and every note do together #1898 , #2258
for now you can remove the meter in the action (transition)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. Yes, those issues have been bothersome from time to time. Happy to do any testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants