Porting ES6 widgets/rhythmruler.js #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@meganindya please review this. |
meganindya
requested changes
Jan 18, 2021
|
I have made the necessary changes. Please have a look! @meganindya |
meganindya
requested changes
Jan 21, 2021
There was a problem hiding this comment.
On clicking clear button:
rhythmruler.js:932 Uncaught ReferenceError: r is not defined
at RhythmRuler._clear (rhythmruler.js:932)
at HTMLDivElement.RhythmRuler.widgetWindow.addButton.onclick (rhythmruler.js:2467)The tap a rhythm button:
rhythmruler.js:177 Uncaught ReferenceError: Cannot access 'frame' before initialization
at __move (rhythmruler.js:177)
at RhythmRuler.__startTapping (rhythmruler.js:192)
at rhythmruler.js:141Uncaught ReferenceError: cell is not defined
at RhythmRuler.__endTapping (rhythmruler.js:196)
at rhythmruler.js:171On clicking the save button:
Uncaught (in promise) ReferenceError: rList is not defined
at RhythmRuler._mergeRulers (rhythmruler.js:2211)
at HTMLDivElement.RhythmRuler.widgetWindow.addButton.onclick (rhythmruler.js:2389)
|
I have tested the code. Hope there are no more errors. @meganindya Please have a look. |
meganindya
force-pushed
the
ES6_rhythmruler.js
branch
from
240e63e
to
8e4a5aa
Compare
|
Pls don't merge |
meganindya
requested changes
Jan 25, 2021
|
Done the changes and formatted the code. @meganindya |
|
You did not reset your local branch to the changes I made. There are conflicts and repeated commits. |
meganindya
force-pushed
the
ES6_rhythmruler.js
branch
2 times, most recently
from
88437b4
to
b1926f0
Compare
function to classes function to classes 2
handling this and that minor changes let/const fix bugs fix bugs
meganindya
force-pushed
the
ES6_rhythmruler.js
branch
from
b1926f0
to
c258b36
Compare
meganindya
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With reference to issue #2629