Fixes regression in overlay of full-screen mode and disables full-screen in some widgets #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksraj123
changed the title
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following
Fixing issue with overlay, steps to reproduce - maximise a widget window by dragging it to the top then minimise it using the minimise icon, the overlay sticks around and could not be removed unless the widgetWindow is closed. Ideal behaviour should be that the overlay should appear only on dragging the window to the top to indicate the window could be maximised and should not stick around in after the window is minimised.
Maximise functionality in all forms (double click, drag to top and maximise button) disabled for the help, tempo, pitch slider, pitch staircase and timbre widgets.
Please share feedback and suggestions. Thanks
@meganindya