-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Fix: Tooltip of Collapse Icon #2878
Conversation
Please review this @meganindya @walterbender. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grid label not showing anymore
Yeah, for some reason only the first 3 tooltips are working out of the 4 function calls. Working on it. |
I have fixed this issue. Please verify and review this @meganindya and let me know if it still has any repercussions. |
js/turtles.js
Outdated
__makeExpandButton(); | ||
__makeClearButton(); | ||
__makeGridButton(); | ||
__makeCollapseButton(); | ||
const $j = jQuery.noConflict(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two calls. Is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be done without declaring $j
and directly using jQuery.noConflict()
. Should I go ahead and remove $j
? @meganindya
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this constant variable in the latest commit. The tooltips are working as expected. Please verify this @meganindya.
Fixes #2876