Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Tooltip of Collapse Icon #2878

Merged
merged 3 commits into from
Mar 11, 2021

Conversation

daksh4469
Copy link
Member

Fixes #2876

@daksh4469
Copy link
Member Author

Please review this @meganindya @walterbender.

Copy link
Member

@meganindya meganindya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grid label not showing anymore

@daksh4469
Copy link
Member Author

daksh4469 commented Mar 11, 2021

Grid label not showing anymore

Yeah, for some reason only the first 3 tooltips are working out of the 4 function calls. Working on it.

@daksh4469
Copy link
Member Author

Grid label not showing anymore

Yeah, for some reason only the first 3 tooltips are working out of the 4 function calls. Working on it.

I have fixed this issue. Please verify and review this @meganindya and let me know if it still has any repercussions.

js/turtles.js Outdated
__makeExpandButton();
__makeClearButton();
__makeGridButton();
__makeCollapseButton();
const $j = jQuery.noConflict();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two calls. Is this needed?

Copy link
Member Author

@daksh4469 daksh4469 Mar 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be done without declaring $j and directly using jQuery.noConflict(). Should I go ahead and remove $j? @meganindya

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this constant variable in the latest commit. The tooltips are working as expected. Please verify this @meganindya.

@meganindya meganindya merged commit 5498cff into sugarlabs:master Mar 11, 2021
@daksh4469 daksh4469 deleted the daksh4469-expandicon branch March 13, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand Icon Hover Compatibility
3 participants