Rhythm Ruler Widget: fix rulers overflowing outside widetWindow and enhancements to fullscreen mode. #2895
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rulers overflow outside the widget window due to this after dissections some notes may completely fall outside the widget window and could not be reached.
Here is a video demonstrating the overflowing rulers issue
Rhythm.ruler.overflowing.outside.widgetWindow.mov
Ref #2808
Currently, the fullscreen mode of the widget has no meaningful functionality. For smaller notes specially notes below (1/32) its difficult to see them in the ruler so it would be helpful if in the fullscreen mode the width of the notes is increased to better utilise the extra space and interact with the rulers.
Here is how the fullscreen mode looks now
Rhythm.ruler.extra.space.not.utilised.in.fullscreen.mode.mov
After Changes
Rhythm.ruler.fix.regression.and.enhancements.mov
Rulers overflowing issue fixed and enhancements made to the fullscreen mode to expand the rulers horizontally, increasing visibility of shorter notes.
Please share feedback and suggestions. Thanks