Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhythm Ruler Widget: fix rulers overflowing outside widetWindow and enhancements to fullscreen mode. #2895

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

ksraj123
Copy link
Member

The rulers overflow outside the widget window due to this after dissections some notes may completely fall outside the widget window and could not be reached.

Here is a video demonstrating the overflowing rulers issue

Rhythm.ruler.overflowing.outside.widgetWindow.mov

Ref #2808
Currently, the fullscreen mode of the widget has no meaningful functionality. For smaller notes specially notes below (1/32) its difficult to see them in the ruler so it would be helpful if in the fullscreen mode the width of the notes is increased to better utilise the extra space and interact with the rulers.

Here is how the fullscreen mode looks now

Rhythm.ruler.extra.space.not.utilised.in.fullscreen.mode.mov

After Changes

Rhythm.ruler.fix.regression.and.enhancements.mov

Rulers overflowing issue fixed and enhancements made to the fullscreen mode to expand the rulers horizontally, increasing visibility of shorter notes.

Please share feedback and suggestions. Thanks

@walterbender walterbender merged commit 1c2044e into sugarlabs:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants