Activity refactor #2943
Merged
Activity refactor #2943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major refactoring of activity.js that eliminates most of the globals and all of the eslint errors. This change has a cacading effect on just about everything else. The commits are in waves, based on the component. I've tried to test everything and the following known bugs will be sorted out before merging:
plugins are broken
myblocks is broken
A few things remain broken from before, such as the handling of the cameraID in the Media Blocks code and some weirdness in the assignment of variables in the Custom Pitch code.
There will be some new strings for translation, since most of the Temperament widget had hardwired English strings.
A few other things were fixed along the way, including restoring custom temperaments upon reloading a project.
Some pending merge requests will need to refactored after this lands:
Everything needs testing. Please comment below on anything you find.