Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File viewer: "hidden" class vs hidden attribute #1928

Closed
justinlittman opened this issue Dec 6, 2023 · 2 comments · Fixed by #1995
Closed

File viewer: "hidden" class vs hidden attribute #1928

justinlittman opened this issue Dec 6, 2023 · 2 comments · Fixed by #1995
Assignees
@justinlittman

Comments

@justinlittman
Copy link
Contributor

image
@justinlittman justinlittman mentioned this issue Dec 6, 2023
Merged
@jcoyne
Copy link
Contributor

jcoyne commented Dec 6, 2023 •
edited
Loading

The treegrid example was coded in 2018, the browser environment has changed in the 5 years since then w3c/aria-practices#762

@justinlittman
Copy link
Contributor Author

We've received clarification that either is acceptable. However, since hidden is cleaner, let's make the change.

@justinlittman justinlittman self-assigned this Dec 13, 2023
justinlittman added a commit that referenced this issue Dec 13, 2023
@justinlittman
Switch to using hidden attribute.
dbfa2bb 
closes #1928
@justinlittman justinlittman mentioned this issue Dec 13, 2023
Merged
justinlittman added a commit that referenced this issue Dec 13, 2023
@justinlittman
Switch to using hidden attribute.
f314c1d 
closes #1928
justinlittman added a commit that referenced this issue Dec 13, 2023
@justinlittman
Switch to using hidden attribute.
a4c3732 
closes #1928
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinlittman justinlittman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to using hidden attribute. sul-dlss/sul-embed
2 participants
@jcoyne @justinlittman