Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DimensionRepository should not need a flush #35

Closed
alexander-schranz opened this issue Nov 5, 2019 · 3 comments
Closed

DimensionRepository should not need a flush #35

alexander-schranz opened this issue Nov 5, 2019 · 3 comments
Labels
Technical Debt Impacts only code quality, no or just small impact on end developers and users

Comments

@alexander-schranz
Copy link
Member

alexander-schranz commented Nov 5, 2019

Currently the DimensionRepository does need a flush before the Dimension can be loaded this should not be the case, the queries should also keep the new unitofwork entities into it.

When Implemented the Skips can be removed from the tests:

if ($skipSave) {
$this->markTestSkipped('Currently not implemented to findOneBy without saving.');
}

Possible Solution:

Create a collection of unit of work entities and use criteria to filter it.

@alexander-schranz alexander-schranz added the Technical Debt Impacts only code quality, no or just small impact on end developers and users label Nov 13, 2019
@niklasnatter
Copy link
Contributor

This is not longer relevant because the DimensionRepositorywas removed in #174

@alexander-schranz
Copy link
Member Author

alexander-schranz commented Jan 14, 2021

@nnatter I think we still have a similar problem with the new DimensionContent when I save a content in a process with en and de it will create 2. It will create 2 unlocalizedDimension which will then end in a unique constraint error when flusing them.

@niklasnatter
Copy link
Contributor

You are right 😕 I saw that you already added #179 for that, so we can keep this closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Technical Debt Impacts only code quality, no or just small impact on end developers and users
Projects
None yet
Development

No branches or pull requests

2 participants