Adjust interface of services to accept locale instead of dimensionAttributes array #84
Labels
Technical Debt
Impacts only code quality, no or just small impact on end developers and users
To Discuss
The core team has to decide if this will be implemented
This issue relates to #87.
Right now, most of the public services of the bundle (
ContentPersister
,ContentWorkflow
,ContentResolver
) accept adimensionAttributes
array. This is needed for flexibility in case somebody adds an additional attribute to theDimension
entity. But it also causes some inconsistencies and makes the interface of this services harder to understand/error prone.For example, we should always change the
DimensionContent
of thedraft
stage when modifying/persisting new content. Unfortunately, right now it is possible to call theContentPersister
with adimensionAttributes
array that contains['stage' => 'live']
. This is probably not desired as it would modify the content of the website but the admin would still display the old content.If we decide to allow only a
stage
and alocale
attribute, we could remove thedimensionAttributes
parameter from the public interface of our services. This would make the services more concise and easier to use.The text was updated successfully, but these errors were encountered: