Limit attributes of Dimension entity to stage and locale #87
Labels
Technical Debt
Impacts only code quality, no or just small impact on end developers and users
To Discuss
The core team has to decide if this will be implemented
Right now, every
DimensionContent
is associated to exactly oneDimension
. The idea behind this architecture is to make theDimension
class overwritable/extendable. This way, if somebody adds atargetGroup
attribute to theDimension
class, it is available for everyContentRichEntity
without any additional configuration.Unfortunately, adding additional properties to the
Dimension
class has complex implications that we have not anticipated. The services for modifying the content need to be aware of the attributes of the dimension to process them correctly. For example, when publishing content, we want to publish theDimensionContent
for a specific locale but all target groups. This means that adding an additionaltargetGroup
requires to change the logic inside thePublishTransitionSubscriber
Furthermore, the possibility of adding additional attributes to the
Dimension
class makes a lot of the code of the bundle very abstract/vague/generic and therefore harder to understand. If we would decide to allow only astage
and alocale
attribute, we could simplify a lot of the code and also our interfaces.The text was updated successfully, but these errors were encountered: