Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit attributes of Dimension entity to stage and locale #87

Closed
niklasnatter opened this issue Feb 25, 2020 · 2 comments
Closed

Limit attributes of Dimension entity to stage and locale #87

niklasnatter opened this issue Feb 25, 2020 · 2 comments
Labels
Technical Debt Impacts only code quality, no or just small impact on end developers and users To Discuss The core team has to decide if this will be implemented

Comments

@niklasnatter
Copy link
Contributor

Right now, every DimensionContent is associated to exactly one Dimension. The idea behind this architecture is to make the Dimension class overwritable/extendable. This way, if somebody adds a targetGroup attribute to the Dimension class, it is available for every ContentRichEntity without any additional configuration.

Unfortunately, adding additional properties to the Dimension class has complex implications that we have not anticipated. The services for modifying the content need to be aware of the attributes of the dimension to process them correctly. For example, when publishing content, we want to publish the DimensionContent for a specific locale but all target groups. This means that adding an additional targetGroup requires to change the logic inside the PublishTransitionSubscriber

Furthermore, the possibility of adding additional attributes to the Dimension class makes a lot of the code of the bundle very abstract/vague/generic and therefore harder to understand. If we would decide to allow only a stage and a locale attribute, we could simplify a lot of the code and also our interfaces.

@niklasnatter niklasnatter added Technical Debt Impacts only code quality, no or just small impact on end developers and users To Discuss The core team has to decide if this will be implemented labels Feb 25, 2020
@wachterjohannes
Copy link
Member

Related to #84

@niklasnatter
Copy link
Contributor Author

Closing this as the Dimension entity was removed in #174

Furthermore, as explained in #84 (comment), I do not think that we should limit the dimensionAttributes anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Technical Debt Impacts only code quality, no or just small impact on end developers and users To Discuss The core team has to decide if this will be implemented
Projects
None yet
Development

No branches or pull requests

2 participants