Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AuthorInterface and dynamic settings form #193

Merged
merged 11 commits into from
Jul 30, 2021
Merged

Add AuthorInterface and dynamic settings form #193

merged 11 commits into from
Jul 30, 2021

Conversation

Prokyonn
Copy link
Member

  • Adds AuthorInterface
  • Adds functionality to dynamically extend the settings tab according to the Custom-Entity and the implemented interfaces

@Prokyonn Prokyonn force-pushed the feature/settings-tab branch from 8641683 to c6654d6 Compare July 29, 2021 14:34
@Prokyonn Prokyonn force-pushed the feature/settings-tab branch from c6654d6 to 49c3604 Compare July 29, 2021 14:35
@coveralls
Copy link

coveralls commented Jul 29, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1082125946

  • 135 of 135 (100.0%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 963428561: 0.0%
Covered Lines: 1907
Relevant Lines: 1907
💛 - Coveralls

@Prokyonn Prokyonn force-pushed the feature/settings-tab branch from f36e65d to 29bf9d0 Compare July 29, 2021 22:43
@Prokyonn Prokyonn marked this pull request as ready for review July 30, 2021 08:38
alexander-schranz
alexander-schranz requested changes Jul 30, 2021
View reviewed changes
Tests/Functional/Integration/responses/example_post.json Outdated Show resolved Hide resolved
Tests/Functional/Integration/responses/example_post_publish.json Outdated Show resolved Hide resolved
Tests/Functional/Integration/responses/example_post_trigger_unpublish.json Outdated Show resolved Hide resolved
Tests/Functional/Integration/responses/example_put.json Outdated Show resolved Hide resolved
Resources/config/forms/content_settings_author.xml Outdated Show resolved Hide resolved
DependencyInjection/Compiler/SettingsFormPass.php Outdated Show resolved Hide resolved
DependencyInjection/Compiler/SettingsFormPass.php Outdated Show resolved Hide resolved
DependencyInjection/Compiler/SettingsFormPass.php Outdated Show resolved Hide resolved
alexander-schranz
alexander-schranz reviewed Jul 30, 2021
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@alexander-schranz alexander-schranz enabled auto-merge (squash) July 30, 2021 12:04
@alexander-schranz alexander-schranz merged commit d6b82d2 into sulu:0.x Jul 30, 2021
@alexander-schranz alexander-schranz mentioned this pull request Oct 15, 2021
Merged
45 tasks
@alexander-schranz alexander-schranz mentioned this pull request Apr 24, 2023
Open
@alexander-schranz alexander-schranz mentioned this pull request Aug 8, 2024
Open
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-schranz alexander-schranz alexander-schranz approved these changes

Assignees

@alexander-schranz alexander-schranz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Prokyonn @coveralls @alexander-schranz