Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade php-cs-fixer #194

Merged
merged 6 commits into from
Sep 14, 2021

Conversation

alexander-schranz
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Sep 14, 2021

Pull Request Test Coverage Report for Build 1233915559

  • 97 of 97 (100.0%) changed or added relevant lines in 35 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1082135591: 0.0%
Covered Lines: 1917
Relevant Lines: 1917

💛 - Coveralls

@alexander-schranz alexander-schranz force-pushed the feature/upgrade-php-cs-fixer branch from f080779 to 23a462a Compare September 14, 2021 09:44
@alexander-schranz alexander-schranz force-pushed the feature/upgrade-php-cs-fixer branch from 053f352 to 9e220e8 Compare September 14, 2021 10:00
@alexander-schranz alexander-schranz force-pushed the feature/upgrade-php-cs-fixer branch from b404bf7 to acd88f0 Compare September 14, 2021 10:07
@@ -9,33 +9,32 @@
with this source code in the file LICENSE.
EOF;

return PhpCsFixer\Config::create()
->setRiskyAllowed(true)
$finder = PhpCsFixer\Finder::create()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is not used? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍

@niklasnatter niklasnatter merged commit bd6674a into sulu:0.x Sep 14, 2021
@alexander-schranz alexander-schranz deleted the feature/upgrade-php-cs-fixer branch September 14, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants