Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase supported PHP version #236

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Mar 20, 2023

For easier maintainance and as support for Sulu 2.4 did end we can now increase the PHP Version for this package as it is 0.x version.

@alexander-schranz alexander-schranz added the DX Only affecting the end developer label Mar 20, 2023
@coveralls
Copy link

coveralls commented Mar 20, 2023

Pull Request Test Coverage Report for Build 4479068992

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 4477935009: 0.0%
Covered Lines: 2392
Relevant Lines: 2392

💛 - Coveralls

@alexander-schranz alexander-schranz force-pushed the feature/increase-supported-php-version branch 6 times, most recently from 7d8923b to 0d05acc Compare March 21, 2023 12:35
@alexander-schranz alexander-schranz force-pushed the feature/increase-supported-php-version branch from 0d05acc to 89dc49d Compare July 17, 2024 08:51
@alexander-schranz alexander-schranz force-pushed the feature/increase-supported-php-version branch from 6bee624 to 9727862 Compare July 17, 2024 08:59
Comment on lines +70 to +71
"doctrine/phpcr-bundle": ">=3.0",
"symfony/security-bundle": ">=7.0"
Copy link
Member Author

@alexander-schranz alexander-schranz Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflicts should be removed in #258

@alexander-schranz alexander-schranz marked this pull request as ready for review July 17, 2024 09:04
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9971301640

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9110205897: 0.0%
Covered Lines: 2518
Relevant Lines: 2518

💛 - Coveralls

@alexander-schranz alexander-schranz merged commit 93b87b8 into sulu:0.x Jul 17, 2024
7 checks passed
@alexander-schranz alexander-schranz deleted the feature/increase-supported-php-version branch July 17, 2024 09:16
@alexander-schranz
Copy link
Member Author

@Prokyonn FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Only affecting the end developer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants