Fix composer lint: phpstan No error to ignore is reported on line 17.
#258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a fix to issue phpstan/phpstan#7685 "Cast to (bool) on string|false !== false should end in non-empty-string"
Since phpstan v1.12.1 the related issue is fixed. phpstan/phpstan#7685 phpstan/phpstan-src#3380
|
@RafaelKr Thx for the pull request, looks like I can not update your branch please make sure to rebase it to the latest version of 2.5 branch: git remote add sulu [email protected]:sulu/skeleton.git
git fetch sulu
git rebase --interactive sulu/2.5 |
|
Hey @alexander-schranz, strange, the "Allow edits by maintainers" is set and also it seems my branch is already based on the latest 2.5 branch of the skeleton Repo (I named it
566732c is also what I see when going to https://github.com/sulu/skeleton/commits/2.5/ Edit: |
|
@RafaelKr Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
We bump phpstan to ^1.12 and remove a
@phpstan-ignore-next-linewe don't require anymore since phpstan/phpstan#7685 ("Cast to (bool) on string|false !== false should end in non-empty-string") is fixed.@alexander-schranz Please let me know if we need the bump of phpstan inside of the composer.json or if I should drop the commit and force-push, thanks!
To Do