Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): add label and validation hint to RadioButtonGroup #665

Merged
merged 3 commits into from
Aug 31, 2020
Merged

feat(components): add label and validation hint to RadioButtonGroup #665

merged 3 commits into from
Aug 31, 2020

Conversation

Inkyov
Copy link
Contributor

@Inkyov Inkyov commented Aug 21, 2020 •
edited by connor-baer
Loading

Purpose

Add label and validation error to the RadioButtonGroup component

Approach and changes

  • Add label
  • Add InlineMessage to show the ValidationHint

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@Inkyov Inkyov requested a review from connor-baer August 21, 2020 13:46
feat(components): add label and validation hint to the radio button g…
36d36b9 
…roup

feature/add-label-validation-hint-radio-button-group

feature/add-label-validation-hint-radio-button-group
@Inkyov Inkyov force-pushed the feature/add-label-validation-hint-radio-button-group branch from 1c5b525 to 36d36b9 Compare August 21, 2020 13:56
@vercel
Copy link

vercel bot commented Aug 21, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/qki9hm9sj
✅ Preview: https://circuit-ui-git-feature-add-label-validation-hint-rad-f55cd2.sumup-oss.vercel.app

@connor-baer connor-baer changed the title feat(components): add label and validation hint to the radio button g… feat(components): add label and validation hint to RadioButtonGroup Aug 24, 2020
@connor-baer connor-baer added the feature A new feature or enhancement label Aug 24, 2020
@connor-baer connor-baer added this to the v2.x milestone Aug 24, 2020
connor-baer
connor-baer requested changes Aug 24, 2020
View reviewed changes
Copy link
Member

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this valuable contribution @Inkyov!

There are a few issues with the markup. Let me know if you have questions about my comments.

src/components/RadioButtonGroup/RadioButtonGroup.stories.tsx Outdated Show resolved Hide resolved
src/components/RadioButtonGroup/RadioButtonGroup.stories.tsx Outdated Show resolved Hide resolved
src/components/RadioButtonGroup/RadioButtonGroup.tsx Outdated Show resolved Hide resolved
src/components/RadioButtonGroup/RadioButtonGroup.tsx Outdated Show resolved Hide resolved
src/components/RadioButtonGroup/RadioButtonGroup.tsx Outdated Show resolved Hide resolved
src/components/RadioButtonGroup/RadioButtonGroup.tsx Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 25, 2020 •
edited
Loading

Codecov Report

Merging #665 into canary will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary     #665      +/-   ##
==========================================
+ Coverage   93.52%   93.54%   +0.02%     
==========================================
  Files         131      131              
  Lines        2240     2247       +7     
  Branches      657      658       +1     
==========================================
+ Hits         2095     2102       +7     
  Misses        119      119              
  Partials       26       26
Impacted Files Coverage Δ
...c/components/RadioButtonGroup/RadioButtonGroup.tsx 100.00% <100.00%> (ø)

@Inkyov Inkyov force-pushed the feature/add-label-validation-hint-radio-button-group branch from e432390 to a93e2a9 Compare August 25, 2020 14:29
@Inkyov Inkyov requested a review from connor-baer August 25, 2020 14:29
feat(components): fix components
ee1ea10 
feature/add-label-validation-hint-radio-button-group

feature/add-label-validation-hint-radio-button-group

feature/add-label-validation-hint-radio-button-group
@Inkyov Inkyov force-pushed the feature/add-label-validation-hint-radio-button-group branch from a93e2a9 to ee1ea10 Compare August 25, 2020 14:34
@Inkyov Inkyov requested a review from connor-baer August 28, 2020 11:15
feat(components): fix components
5482d6d 
feature/add-label-validation-hint-radio-button-group

feature/add-label-validation-hint-radio-button-group
@Inkyov Inkyov force-pushed the feature/add-label-validation-hint-radio-button-group branch from 4ce6276 to 5482d6d Compare August 28, 2020 11:19
connor-baer
connor-baer approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 🥇 Thank you so much for polishing this!

@Inkyov Inkyov merged commit aeef592 into canary Aug 31, 2020
@Inkyov Inkyov deleted the feature/add-label-validation-hint-radio-button-group branch August 31, 2020 06:54
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.1.0-canary.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connor-baer connor-baer connor-baer approved these changes

Assignees
No one assigned
Labels
feature A new feature or enhancement
Projects
None yet
Milestone
v2.x
Development

Successfully merging this pull request may close these issues.
2 participants
@Inkyov @connor-baer