feat(components): move Aggregator to TypeScript and add tracking to it (via useClickTracker) #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move Aggregator to TS add tracking (via useClickTracker) to the Aggregator component feature/add-tracking-sidebar-aggregator
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/g5w7tntc2 |
Codecov Report
@@ Coverage Diff @@
## canary #667 +/- ##
==========================================
- Coverage 93.54% 93.49% -0.05%
==========================================
Files 131 131
Lines 2245 2245
Branches 657 654 -3
==========================================
- Hits 2100 2099 -1
- Misses 119 120 +1
Partials 26 26
|
amelako
approved these changes
Aug 27, 2020
connor-baer
approved these changes
Aug 27, 2020
|
🎉 This PR is included in version 2.1.0-canary.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In order to add tracking to the
Aggregator, I've decided to move it to TS to standardize the component.Approach and changes
Definition of done