You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
The current "version": "0.4.0" of webfonts-generator includes "svgicons2svgfont": "^5.0.0", whose latest minor version is six months old. They're currently at "version": "8.0.0".
Worse still, "svgicons2svgfont": "^5.0.0" appears to be including "svg-pathdata": "^1.0.4", which is a year old. They're currently at "version": "4.0.1".
All this is important to me because bugs have cropped up for me in svg-pathdata while using icon-font-generator (which uses webfonts-generator) and I can't tell if the problems might be resolved simply by being up to date.
The text was updated successfully, but these errors were encountered:
I forked the repo and updated the dependencies, then ran the tests. The tests passed, except for a small issue with the RENDERED_TEMPLATE having a return character \r before the newline. I updated the test too so that it passed. The only other update I had to make was calling svgicons2svgfont with new.
Mind testing it out? Should anything else be done before submitting a PR?
You are very welcome @bdjnk. It also resolved some quirks I noticed with my own SVG icons.
Wondering how to push the PR forward though - not a lot of experience on my end committing to public open source projects like this. Any tips or suggestions? Looks like part of the reason my PR failed was due to some outdated node versions so that's immediately a major release. I get that, but no response from the maintainer :/
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The current
"version": "0.4.0"
ofwebfonts-generator
includes"svgicons2svgfont": "^5.0.0"
, whose latest minor version is six months old. They're currently at"version": "8.0.0"
.Worse still,
"svgicons2svgfont": "^5.0.0"
appears to be including"svg-pathdata": "^1.0.4"
, which is a year old. They're currently at"version": "4.0.1"
.All this is important to me because bugs have cropped up for me in svg-pathdata while using icon-font-generator (which uses
webfonts-generator
) and I can't tell if the problems might be resolved simply by being up to date.The text was updated successfully, but these errors were encountered: