Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Day 13 : Order class's calculate method is not pure #6

Open
havanagrawal opened this issue Jun 11, 2017 · 1 comment
Open

Day 13 : Order class's calculate method is not pure #6

havanagrawal opened this issue Jun 11, 2017 · 1 comment
Labels

Comments

@havanagrawal
Copy link
Contributor

Calling calculate on a given Order should return the same value, regardless of how many times it is called.

The current implementation will return a new, increased value each time.

https://github.com/sunnypatel165/31DaysOfRefactoringInJava/blob/master/src/com/sunnypatel/daysofrefactoringjava/day13/extractmethodobjects/problem/Order.java#L20-L30

@sunnypatel165
Copy link
Owner

What should be the case? Should I initialize all variables locally? - remember its a "bad" example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants