Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Project to Support DI and Nullity #36

Merged
merged 9 commits into from
Nov 13, 2022
Merged

Restructure Project to Support DI and Nullity #36

merged 9 commits into from
Nov 13, 2022

Commits on Nov 10, 2022

  1. Update child modules and update codebase to implement them

    @acupofjose
    acupofjose committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    add5229 View commit details
    Browse the repository at this point in the history

  2. Create interfaces for publicly available classes.

    @acupofjose
    acupofjose committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    a9f8a59 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Update tests and stub fake DI clients.

    @acupofjose
    acupofjose committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    8309cc3 View commit details
    Browse the repository at this point in the history

  2. Implemented changes suggested by @veleek

    @acupofjose
    acupofjose committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    c16e659 View commit details
    Browse the repository at this point in the history

  3. Fix regression on GetAuthHeaders

    @acupofjose
    acupofjose committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    4ac9a8c View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2022

  1. Implemented changes suggested by @veleek

    @acupofjose
    acupofjose committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    6645e38 View commit details
    Browse the repository at this point in the history

  2. - Add a constructor that accepts the clients as arguments. 

    - Fix scope on private variables that are only used at initialization.
    @acupofjose
    acupofjose committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    70433fe View commit details
    Browse the repository at this point in the history

  3. Final adjustments to remove redundant headers call and unused supabas… 

    …eKey argument
    @acupofjose
    acupofjose committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    a750c1f View commit details
    Browse the repository at this point in the history

  4. Additional comments prior to merge

    @acupofjose
    acupofjose committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    374134f View commit details
    Browse the repository at this point in the history