fix: return 404 instead of 200 for stale assets with `adapter-cloudfl…

…are` (#6879) * [fix] return 404 instead of 200 for stale assets * [chore] code format * Create healthy-rivers-share.md Co-authored-by: Rich Harris <[email protected]>
sveltejs · Sep 19, 2022 · ae2e4bf · ae2e4bf
1 parent 2ae753a
commit ae2e4bf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/healthy-rivers-share.md b/.changeset/healthy-rivers-share.md
@@ -0,0 +1,5 @@
+---
+"@sveltejs/adapter-cloudflare": patch
+---
+
+[fix] return 404 instead of 200 for missing assets
diff --git a/packages/adapter-cloudflare/src/worker.js b/packages/adapter-cloudflare/src/worker.js
@@ -20,6 +20,7 @@ const worker = {
 		// static assets
 		if (pathname.startsWith(prefix)) {
 			res = await env.ASSETS.fetch(req);
+			if (!res.ok) return res;
 
 			const cache_control = pathname.startsWith(prefix + 'immutable/')
 				? 'public, immutable, max-age=31536000'
@@ -65,7 +66,7 @@ const worker = {
 
 		// Writes to Cache only if allowed & specified
 		pragma = res.headers.get('cache-control');
-		return pragma ? Cache.save(req, res, context) : res;
+		return pragma && res.ok ? Cache.save(req, res, context) : res;
 	}
 };