[fix] explicitly add kit to ssr.noExternal (#2306)

sveltejs · Aug 28, 2021 · e21892b · e21892b
1 parent 8c53262
commit e21892b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/.changeset/short-emus-juggle.md b/.changeset/short-emus-juggle.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/kit': patch
+---
+
+Add `@sveltejs/kit` to noExternal to resolve hooks module in dev server
diff --git a/packages/kit/src/core/build/index.js b/packages/kit/src/core/build/index.js
@@ -488,10 +488,12 @@ async function build_server(
 			}
 		},
 		ssr: {
-			// note to self: this _might_ need to be ['svelte', '@sveltejs/kit', ...get_no_external()]
-			// but I'm honestly not sure. roll with this for now and see if it's ok
-			// @ts-expect-error - ssr is considered in alpha, so not yet exposed by Vite
-			noExternal: [...((vite_config.ssr && vite_config.ssr.noExternal) || []), ...svelte_packages]
+			noExternal: [
+				'@sveltejs/kit', // TODO: see https://github.com/vitejs/vite/issues/3953
+				// @ts-expect-error - ssr is considered in alpha, so not yet exposed by Vite
+				...((vite_config.ssr && vite_config.ssr.noExternal) || []),
+				...svelte_packages
+			]
 		}
 	});