Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoadOutput types incorrect #1606

Closed
madeleineostoja opened this issue May 30, 2021 · 0 comments · Fixed by #1617
Closed

LoadOutput types incorrect #1606

madeleineostoja opened this issue May 30, 2021 · 0 comments · Fixed by #1617
Labels
bug Something isn't working types / typescript
Milestone

Comments

@madeleineostoja
Copy link

Describe the bug
From what I understand load should be able to return undefined in order to trigger a fallthrough to a 404 page. Currently that results in a type error because LoadOutput expects an object, which in my testing doesn't trigger a fallthrough, even if empty.

Logs
N/A

To Reproduce
Return nothing from a typed load function, inspect the type error given.

Expected behavior
load should be able to return undefined or null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working types / typescript
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants