Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'The following Vite config options will be overridden by SvelteKit' message is hidden #5540

Closed
Rich-Harris opened this issue Jul 14, 2022 · 1 comment · Fixed by #5563
Closed
Labels
bug Something isn't working help wanted PRs welcomed. The implementation details are unlikely to cause debate low hanging fruit p1-important SvelteKit cannot be used by a large number of people, basic functionality is missing, etc.
Milestone

Comments

@Rich-Harris
Copy link
Member

Describe the bug

If you set a value in vite.config.js that SvelteKit needs to control, like base, a message is printed:

image

I had to add clearScreen: false to the Vite config to take that screenshot, because normally the message is immediately hidden by Vite's welcome message. Not sure if there's a way to either preserve the message or print it immediately after the welcome message?

Reproduction

https://stackblitz.com/edit/sveltejs-kit-template-default-pmx9s3?file=vite.config.js&terminal=dev

Logs

No response

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (4) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.10 - /bin/yarn
    npm: 7.17.0 - /bin/npm
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.60 
    @sveltejs/kit: next => 1.0.0-next.373 
    svelte: ^3.46.0 => 3.49.0 
    vite: ^3.0.0 => 3.0.0

Severity

annoyance

Additional Information

No response

@bluwy
Copy link
Member

bluwy commented Jul 15, 2022

It can be printed after the welcome message by listening for Vite's http server start, and log after a setTimeout. Me and dominik did this for printing qrcode's after the welcome message.

@Rich-Harris Rich-Harris added bug Something isn't working help wanted PRs welcomed. The implementation details are unlikely to cause debate low hanging fruit labels Jul 15, 2022
@Rich-Harris Rich-Harris added this to the 1.0 milestone Jul 15, 2022
@benmccann benmccann added p1-important SvelteKit cannot be used by a large number of people, basic functionality is missing, etc. low hanging fruit and removed low hanging fruit labels Jul 19, 2022
@Rich-Harris Rich-Harris modified the milestones: 1.0, whenever Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted PRs welcomed. The implementation details are unlikely to cause debate low hanging fruit p1-important SvelteKit cannot be used by a large number of people, basic functionality is missing, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants