Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delay emptying dist folder in svelte-package #10514

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

kwangure
Copy link
Contributor

@kwangure kwangure commented Aug 9, 2023

Fixes #10507

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023

🦋 Changeset detected

Latest commit: 972fbbb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/package Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@ARed99 ARed99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proceed

@benmccann benmccann added the pkg:svelte-package Issues related to svelte-package label Aug 9, 2023
Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than a minor suggestion on the changeset

.changeset/red-dots-notice.md Outdated Show resolved Hide resolved
@benmccann benmccann merged commit 118a3a6 into sveltejs:master Aug 10, 2023
@github-actions github-actions bot mentioned this pull request Aug 10, 2023
Elia872 pushed a commit to Elia872/kit that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:svelte-package Issues related to svelte-package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delay emptying of dist folder in package
4 participants