-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use correct environment file for rendering spa fallback page #10963
Conversation
🦋 Changeset detectedLatest commit: 670d6d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move the test to adapter-static/test/apps/spa
? I think the fallback page test fits better there since it already has one among the other SPA tests. We can also extend the +error.svelte
file to display the environment variable value then navigate to a non-existent route to see the value.
Other than that, it looks really good to me! Thank you!
packages/adapter-static/test/apps/spa/src/routes/fallback/[...rest]/+page.svelte
Show resolved
Hide resolved
Co-authored-by: Tee Ming <[email protected]>
Thank you! |
fixes #10801
The
adapter-static
fallback page is hardcoded to useproduction
environment variables (this is defined inkit
and called fromadapter-static
). This PR uses the correct environment specified byvite_config.mode
.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.