-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vitest 1.0 #11196
feat: vitest 1.0 #11196
Conversation
🦋 Changeset detectedLatest commit: 7697324 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -0,0 +1,5 @@ | |||
--- | |||
'create-svelte': minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a major because vitest also requires node18 ? ultimately we are going to do more changes to the templates in create-svelte that cause a major so not sure it matters much apart from where in the changelog its listed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good question. We have lots of things causing a major elsewhere but nothing on create-svelte
yet. If we want to do a major this wouldn't be a bad PR to do it in. I don't know if we're worried about that causing issues on StackBlitz, etc. or anywhere like that
I could also edit the changeset where we dropped Node 16 support to include this package
No description provided.