-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking: Remove dangerZone.trackServerFetches
#11235
Conversation
🦋 Changeset detectedLatest commit: a3a52bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Will |
Yeah, wasn't sure what we wanted to do with that -- seems like it'd be good to have an established place to put experimental or security-related things like this, and it also seemed weird to remove it and re-add it later. |
* Automatically add server-side `fetch`ed URLs to the `dependencies` map of `load` functions. This will expose secrets | ||
* to the client if your URL contains them. | ||
*/ | ||
trackServerFetches?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm. I wonder if we should leave this in the docs for now with a note that it was only available in 1.0 in case anyone wants to refer to what the option did in 1.0. It's kind of unfortunate that would also expose it publicly though. Maybe there's a way to merge in type declarations that are only used for generating the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could always change it to trackServerFetches: never
and mark it deprecated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That probably works well enough
I'd be okay with removing and re-adding later if we need it again |
Just checking, did you see Ben's comment? Might be good to leave it in with an |
I would remove it from |
We can mention it in the migration docs, then it still shows up in search somewhere, and we can remove it here |
That works for me. Let's start a migration doc with that one note in it as part of this PR so that we don't forget |
Started in #11199 |
We had to make a breaking change in #9945, so we added this option to give people who knew it was safe an easy way to keep their apps running while they implemented fixes. Since we're releasing 2.0, we can remove this security-related override.
Closes #11234
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.