-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shallow routing #11307
Merged
Merged
Shallow routing #11307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5c6e6ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… future-proof, as we may add options in future
This was referenced Dec 14, 2023
ignatiusmb
reviewed
Dec 14, 2023
dummdidumm
reviewed
Dec 14, 2023
Co-authored-by: Ignatius Bagus <[email protected]>
…andling a click event, and avoid
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2673. This is a continuation of #9847, on top of the
version-2
branch. Copying the TODOs from that PR:App.PageState
and other typesgoto(url, { state })
history.pushState
andhistory.replaceState
to discourage their useinvalidateAll()
should probably use$page.url.href
rather thanlocation.href
, since those two things can now be differentfix bugginess around reloads. If you push state and refresh the page, you go to pushed URL (as intended), and hitting the back button will take you to the page you came from, but only because there's special handling for that case. If you push state and click from there to a new page, then reload that page, clicking back twice won't work as expected. Still looking into how to fix this. possibly nuke navigation index history on page reload? unless there's a better wayactually i'm not sure what this referred toPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.