Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly trailing slash redirect when navigating from root page #11357

Merged
merged 7 commits into from
Dec 17, 2023

Conversation

eltigerchino
Copy link
Member

fixes #11317

#10763 introduces a bug where the trailing slash option at the root page is set to always. This PR checks if a base config is set before setting trailing slash to always for the root page.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Dec 16, 2023

🦋 Changeset detected

Latest commit: 56e3d4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann merged commit fa31ad1 into master Dec 17, 2023
10 of 13 checks passed
@benmccann benmccann deleted the fix-trailing-slash-redirect-from-root branch December 17, 2023 01:56
@github-actions github-actions bot mentioned this pull request Dec 16, 2023
@benmccann
Copy link
Member

thanks! I just tweaked a couple docs type stuff. looks good to me! really appreciate the fix - a lot of people have been hitting this!

@eltigerchino
Copy link
Member Author

Thanks for fixing it up and reviewing this on a weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default behaviour of trailingSlash violated
2 participants