-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly trailing slash redirect when navigating from root page #11357
Conversation
🦋 Changeset detectedLatest commit: 56e3d4b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/kit/test/apps/basics/test/cross-platform/client.test.js
Outdated
Show resolved
Hide resolved
packages/kit/test/apps/basics/test/cross-platform/client.test.js
Outdated
Show resolved
Hide resolved
thanks! I just tweaked a couple docs type stuff. looks good to me! really appreciate the fix - a lot of people have been hitting this! |
Thanks for fixing it up and reviewing this on a weekend! |
fixes #11317
#10763 introduces a bug where the trailing slash option at the root page is set to always. This PR checks if a base config is set before setting trailing slash to always for the root page.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.