-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: overhaul ignore configs #11938
Merged
Merged
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fd2eb3c
chore: overhaul ignore configs
hyunbinseo 8d11dd9
revert: lockfiles in eslint ignore
hyunbinseo f758eef
chore: update env ignore
hyunbinseo ebba193
chore: unify git-ignore files
hyunbinseo 3731426
chore: add package manager category
hyunbinseo 9a1c994
chore: remove .eslintignore for eslint v9
hyunbinseo 13514fb
revert: .env filename in .gitignore
hyunbinseo f04dc86
Update packages/create-svelte/templates/default/.gitignore
benmccann fac86da
Update packages/create-svelte/templates/skeleton/.gitignore
benmccann 3778982
Update packages/create-svelte/templates/skeletonlib/.gitignore
benmccann 30c1686
Update packages/create-svelte/templates/default/.gitignore
benmccann 85c15de
Update packages/create-svelte/templates/skeleton/.gitignore
benmccann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "create-svelte": patch | ||
| --- | ||
|
|
||
| chore: overhaul ignore configs |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,12 @@ | ||
| .DS_Store | ||
| /package | ||
| node_modules | ||
| /build | ||
|
|
||
| # Output | ||
| /.svelte-kit | ||
| /package | ||
| .env | ||
| .env.* | ||
| !.env.example | ||
| /build | ||
| /dist | ||
|
|
||
| # Ignore files for PNPM, NPM and YARN | ||
hyunbinseo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| pnpm-lock.yaml | ||
| # Lockfiles | ||
| package-lock.json | ||
| pnpm-lock.yaml | ||
| yarn.lock | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # Ignore files for PNPM, NPM and YARN | ||
| pnpm-lock.yaml | ||
| # Lockfiles | ||
| package-lock.json | ||
| pnpm-lock.yaml | ||
| yarn.lock |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,21 @@ | ||
| .DS_Store | ||
| .output | ||
| .vercel | ||
| /package | ||
| node_modules | ||
| /build | ||
|
|
||
| # Output | ||
hyunbinseo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| /.svelte-kit | ||
| /package | ||
| .env | ||
hyunbinseo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| /build | ||
|
|
||
| # OS | ||
| .DS_Store | ||
| Thumbs.db | ||
|
|
||
| # Env | ||
| .env.* | ||
| !.env.example | ||
| .vercel | ||
| .output | ||
| !.env.test | ||
|
|
||
| # Vite | ||
| vite.config.js.timestamp-* | ||
| vite.config.ts.timestamp-* | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,19 @@ | ||
| .DS_Store | ||
| /package | ||
| node_modules | ||
| /build | ||
|
|
||
| # Output | ||
| /.svelte-kit | ||
| /package | ||
| .env | ||
| /build | ||
|
|
||
| # OS | ||
| .DS_Store | ||
| Thumbs.db | ||
|
|
||
| # Env | ||
| .env.* | ||
| !.env.example | ||
| !.env.test | ||
|
|
||
| # Vite | ||
| vite.config.js.timestamp-* | ||
| vite.config.ts.timestamp-* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,20 @@ | ||
| .DS_Store | ||
| /package | ||
| node_modules | ||
|
|
||
| # Output | ||
| /.svelte-kit | ||
| /build | ||
| /dist | ||
| /.svelte-kit | ||
| /package | ||
| .env | ||
|
|
||
| # OS | ||
| .DS_Store | ||
| Thumbs.db | ||
|
|
||
| # Env | ||
| .env.* | ||
| !.env.example | ||
| !.env.test | ||
|
|
||
| # Vite | ||
| vite.config.js.timestamp-* | ||
| vite.config.ts.timestamp-* |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't this be considered "Output"?
I think if you changed the "Lockfiles" head to "Package managers" then you could put
node_modulesthere tooThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't certain about the
/packagesdirectory. When is it used? The package template uses thedistdirectory.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps we don't need it anymore. it may be leftover. I think svelte-kit package used to output to that location