Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shuffle things around a bit #3327

Merged
merged 36 commits into from
Jan 14, 2022
Merged

shuffle things around a bit #3327

merged 36 commits into from
Jan 14, 2022

Conversation

Rich-Harris
Copy link
Member

this is a checkpoint on the way to #3322, which I can't seem to get to work in CI. figured it'd be easier to get the reorganisation stuff done separately, then try to tackle the src/build thing

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2022

⚠️ No Changeset found

Latest commit: 77854f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jan 13, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 77854f3

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61e0f6bdb3c6b70008aaaa25

packages/kit/.gitignore Outdated Show resolved Hide resolved
Co-authored-by: Ignatius Bagus <[email protected]>
Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - though I didn't look super closely since it doesn't seem like there are any huge changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(netlify): Package subpath './hooks' is not defined by "exports"
4 participants