-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing platform context from adapters #3429
Merged
Merged
Changes from 32 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
d574cb6
Can pass locals at app.render
fezproof 33d4737
Updated cloudflare workers to pass in env to locals
fezproof 56bfe37
Fixed other adapters for new API
fezproof 8309cd7
Fixed naming in app types to be more consistent
fezproof bb67019
Merge branch 'master' into locals-from-adapter
Rich-Harris 9f95150
Updated to use meta in stead of polluting locals
fezproof 4f4247c
updated adapter cloudflare to use meta
fezproof fd9a6f5
Added changesets
fezproof df36652
Formated and linted
fezproof 6d34a4c
Updated types to include Meta consistently
fezproof 2d887a3
Updated documentation to include information about the meta object
fezproof bcd3c8d
Fixed type issue in hooks
fezproof 36b139a
Merge branch 'master' of https://github.com/sveltejs/kit into locals-…
fezproof eb977ea
Updated naming to platform
fezproof a9d3fa9
Added a way to get the original request from the node adapter
fezproof 8745a71
Made platform Readonly in RequestEvent
fezproof 40f8cd7
Fixed typo in docs
fezproof 201e595
Update documentation/docs/01-routing.md
fezproof 0bce46d
Fixed bad spaces
fezproof e95e1b3
Merge branch 'master' into locals-from-adapter
fezproof 741eda4
Fixed merge issues
fezproof 19d5039
Merge branch 'master' into locals-from-adapter
ignatiusmb 2f6cb31
rerun flakey tests
fezproof c7b10a1
rerun flakey tests 2
fezproof e4a1047
Update documentation/docs/10-adapters.md grammer
fezproof d91beaf
rerun flakey tests 3
fezproof 22c2e6f
Merge branch 'locals-from-adapter' of https://github.com/fezproof/kit…
fezproof 492809d
rerun flakey tests 4
fezproof e4c7be7
Changed node handler to pass in `req`
fezproof bb2ddaa
Updated cloudflare readme
fezproof e5fd336
Renamed to request
fezproof 4e96cf1
Use Record<string, any>
fezproof 9fc934b
rerun flakey tests 5
fezproof 72459fe
change API to app.render(request, opts)
Rich-Harris 54de5bf
update adapters
Rich-Harris d417d00
use platform.req instead of platform.request — more idiomatic
Rich-Harris e68d469
remove changesets for unaffected adapters
Rich-Harris 358c747
tweak changesets
Rich-Harris 2a4b54b
remove platform stuff from routing section
Rich-Harris 9d57b6c
tweak adapter docs
Rich-Harris a3121b8
Merge branch 'master' into locals-from-adapter
Rich-Harris 6e90095
Fix documentation/docs/04-hooks.md spaces
fezproof 9ca9144
remove changes to adapter-node
Rich-Harris 5d3c3ae
create-svelte is unchanged
Rich-Harris 983ec4f
simplify docs
Rich-Harris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
--- | ||
'@sveltejs/adapter-auto': patch | ||
'@sveltejs/adapter-cloudflare': patch | ||
'@sveltejs/adapter-cloudflare-workers': patch | ||
'@sveltejs/adapter-netlify': patch | ||
'@sveltejs/adapter-node': patch | ||
'@sveltejs/adapter-vercel': patch | ||
--- | ||
|
||
Updated adapters to work with new `app.render` API |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'create-svelte': patch | ||
'@sveltejs/kit': patch | ||
--- | ||
|
||
Adapter render API updated to allow `meta` value |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be changed back to a tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what is causing this one, can't find a setting that would do it. Fixed now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code blocks in markdown files aren't linted. If it's just a regular
.js
file it should be handled thoughThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still doesn't look fixed.