-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Lazy load Svelte components to reenable no-ssr use cases #5930
Conversation
🦋 Changeset detectedLatest commit: ab1e880 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
// String representation of | ||
/** @type {import('types').SSRNode} */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is kind of a confusing way to write the comment. maybe something like this?
// String representation of | |
/** @type {import('types').SSRNode} */ | |
// String representation of types.SSRNode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I specifically wrote it like this so that you can do "find usages" on the type and it takes you to this place. This would have been helpful to me to find the correct places I need to change quicker.
I feared this would happen - this CSS tests are failing, I guess because they are no longer eagerly imported so it's a FOUC in some cases. |
Fixes #5909
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0