-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking] add error.html #6367
Conversation
This is a static error page that will be rendered by the server when everything else goes wrong Closes #3068
🦋 Changeset detectedLatest commit: 2a3e2af The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
export async function load() { | ||
if (should_fail) { | ||
set_should_fail(false); | ||
throw new Error('Failed to load'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is somewhat nasty, but the idea could also be reused to test the invalidate()
bug I fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from the looks of it this could cause raciness if tests are running in parallel. not suggesting we change anything, just noting it so we know where to look if that starts happening
We definitely need to include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the error page dynamic with respect to status / message
Migration
kit.config.files.template
has been renamed tokit.config.files.appTemplate
to be more consistent with the newkit.config.files.errorTemplate
option.PR description
This is a static error page that will be rendered by the server when everything else goes wrong
Closes #3068
Implementing this brought up some design questions around how dynamic the error page is. The places I added it previously showed the error message and possibly the stack trace in dev, which is no longer the case. Should we have something like an optional placeholder named
%sveltekit.error%
which is passed the stringified message, and in dev also the stack trace?Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0